fix: account for onlyFavorites filter in candidateIds (#37) #38
+46
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #37 by ensuring the
onlyFavoritesfilter is properly respected when building and navigating the Pokémon list.Changes Included
pokemonController.ts: UpdatedcandidateIdslogic inGetNextFilteredandGetPrevFilteredto filter candidate IDs based on theonlyFavoritesstate.PokemonList.tsx: PassedfavoriteIdstomatchesFilterso the favorites view correctly applies filter rules and renders matching Pokémon without unnecessary API calls.Verification
npm test run(passing).npm run dev: verified that toggling Only Favorites limitsPrev/Nextnavigation exclusively to favorited Pokémon.Closes #37